Fix positions in assignments #2872
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TreeCopier#finalize will set the position of the new tree to the old tree, which is not what we want here since the desugared tree position should contain more than the position of the parsed assignment lhs. Moreover, the desugared tree will never be identical to the parsed lhs so there is no reason to use a TreeCopier at all.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TreeCopier#finalize will set the position of the new tree to the old
tree, which is not what we want here since the desugared tree position
should contain more than the position of the parsed assignment lhs.
Moreover, the desugared tree will never be identical to the parsed lhs
so there is no reason to use a TreeCopier at all.